Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libbacktrace pretty-printing #56718

Merged
merged 2 commits into from
Dec 15, 2018
Merged

Use libbacktrace pretty-printing #56718

merged 2 commits into from
Dec 15, 2018

Conversation

RalfJung
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2018
@alexcrichton
Copy link
Member

@bors: r+ rollup

always happy to help delete code :)

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit a24565218e906097bd43db2348cdd9e078e78038 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:02dd6c7c:start=1544553219482254895,finish=1544553220600916814,duration=1118661919
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:46:16]    Compiling failure v0.1.3
[00:46:16] error[E0034]: multiple applicable items in scope
[00:46:16]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.3/src/backtrace/mod.rs:132:20
[00:46:16]     |
[00:46:16] 132 |                 bt.fmt(f)
[00:46:16]     |                    ^^^ multiple `fmt` found
[00:46:16]     |
[00:46:16]     = note: candidate #1 is defined in an impl of the trait `std::fmt::Debug` for the type `backtrace::backtrace::Backtrace`
[00:46:16]     = note: candidate #2 is defined in an impl of the trait `std::fmt::Display` for the type `backtrace::backtrace::Backtrace`
[00:46:16] error[E0034]: multiple applicable items in scope
[00:46:16]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.3/src/backtrace/mod.rs:140:20
[00:46:16]     |
[00:46:16]     |
[00:46:16] 140 |                 bt.fmt(f)
[00:46:16]     |                    ^^^ multiple `fmt` found
[00:46:16]     error: build failed
[00:46:16] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/compiletest/Cargo.toml" "--message-format" "json"
[00:46:16] expected success, got: exit code: 101
[00:46:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:16] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:46:16] Build completed unsuccessfully in 0:00:51
[00:46:16] make: *** [check] Error 1
[00:46:16] Makefile:58: recipe for target 'check' failed
122892 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release
115664 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps
115340 ./src/llvm/test/CodeGen
107892 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
---
travis_time:end:2208208e:start=1544556006901013071,finish=1544556006907334300,duration=6321229
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:191e172a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@RalfJung
Copy link
Member Author

@bors r-

[00:46:16] error[E0034]: multiple applicable items in scope
[00:46:16]    --> /cargo/registry/src/github.com-1ecc6299db9ec823/failure-0.1.3/src/backtrace/mod.rs:132:20
[00:46:16]     |
[00:46:16] 132 |                 bt.fmt(f)
[00:46:16]     |                    ^^^ multiple `fmt` found

This conflicts with failure 0.1.3, unfortunately.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2018
@RalfJung RalfJung mentioned this pull request Dec 11, 2018
Closed
@RalfJung
Copy link
Member Author

With backtrace 0.3.11, the compat-problems should be gone.

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit 8e994a2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Dec 12, 2018
@kennytm
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
d8c198e 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@kennytm kennytm mentioned this pull request Dec 12, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 12, 2018
@pietroalbini
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
9d888a2 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Dec 12, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 13, 2018
@pietroalbini
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
514ef65 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Dec 13, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 13, 2018
@kennytm
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
f7889e1 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@kennytm kennytm mentioned this pull request Dec 13, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
@kennytm
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
b1ad363 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@kennytm kennytm mentioned this pull request Dec 14, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
@kennytm
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
bc8aef6 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@kennytm kennytm mentioned this pull request Dec 14, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 14, 2018
@pietroalbini
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
c6ff109 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Dec 14, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 15, 2018
@pietroalbini
Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…
9f3151a 
… r=alexcrichton

Use libbacktrace pretty-printing

r? @alexcrichton
@pietroalbini pietroalbini mentioned this pull request Dec 15, 2018
Merged
bors added a commit that referenced this pull request Dec 15, 2018
@bors
Auto merge of #56840 - pietroalbini:rollup, r=pietroalbini
0a1b226 
Rollup of 14 pull requests

Successful merges:

 - #56718 (Use libbacktrace pretty-printing)
 - #56725 (fix rust-lang/rust issue #50583)
 - #56731 (Add missing urls in ffi module docs)
 - #56738 (Fix private_no_mangle_fns message grammar)
 - #56746 (Add test of current behavior (infer free region within closure body))
 - #56747 (target: remove Box returned by get_targets)
 - #56751 (Allow ptr::hash to accept fat pointers)
 - #56755 (Account for `impl Trait` when suggesting lifetime)
 - #56758 (Add short emoji status to toolstate updates)
 - #56760 (Deduplicate unsatisfied trait bounds)
 - #56769 (Add x86_64-unknown-uefi target)
 - #56792 (Bootstrap: Add testsuite for compiletest tool)
 - #56808 (Fixes broken links)
 - #56809 (Fix docs path to PermissionsExt)

Failed merges:

r? @ghost
@bors bors merged commit 8e994a2 into rust-lang:master Dec 15, 2018
@RalfJung RalfJung deleted the use-libbacktrace-printing branch January 9, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @alexcrichton @bors @rust-highfive